Plane: correct RTL_AUTOLAND=1 behaviour #26413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/autotest-RTL_AUTOLAND-1
branch
3 times, most recently
from
48b13a4 to
af1b12a
Compare
peterbarker
changed the title
peterbarker
force-pushed
the
pr/autotest-RTL_AUTOLAND-1
branch
from
af1b12a to
774bf1b
Compare
we are calling "reached_loiter_target" as part of our checks as to whether to fly home or not. We need to call update_loiter so the L1 controller can update its internal state for the new waypoint which do_RTL has set. Depending on location (but typically), that will mean that L1's reached_loiter_target() will then return false, so we fly home. This bug was affected by f8d7be5 . Any sort of altitude error greater than 10m would delay us entering the landing sequence, allowing the L1 controller to update its state.
peterbarker
force-pushed
the
pr/autotest-RTL_AUTOLAND-1
branch
from
774bf1b to
e8808c3
Compare
|
Still waiting for partner to test. |
tridge
approved these changes
Apr 10, 2024
|
This is included in 4.5.2-beta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autotest added for same